fix: keep review outcome counts bound to their CSV digest - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a workpaper was saved between read_bytes() and read_csv(path), the summary could count an updated exception while citing the earlier pending workpaper's SHA-256. Parse the original selection and completed review from the same captured byte buffers used for their digests.
Add a regression that replaces the file during validation and checks counts against the version identified by the reported digest. Update the documented test count and explain the snapshot boundary.
Validation: complete pipeline ran successfully, including 15 SQL queries; all 464 pytest cases passed locally with pandas 3.0.6; Ruff and git diff --check passed. Generated charts/reports are excluded from this change.