Handle finite feature values and overflow-safe rolling aggregates - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid JSON integer values outside signed int64 previously failed at SQLite binding, although the Python reference accepted them. Rolling sums also rejected finite results after intermediate overflow, and means rejected two 1e308 inputs despite their finite 1e308 average.
Convert observation values explicitly to binary64 at the SQL boundary while retaining original values in normalized evidence. Reject unrepresentable integer inputs with a contract error. Keep compensated summation for ordinary inputs and use an exact-ratio fallback for exceptional binary64 sum/mean overflow. Document rounding and monetary limits.
Validation: 75 unittest cases passed locally; new regression cases reproduced the original failures. Both committed snapshot and rolling bundles replay byte-for-byte. git diff --check passed.