Reject unsafe backtest settings and honor fractional-share controls - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 1.9-session execution lag was silently truncated to one session, string "false" enabled fractional fills, and negative transaction-cost assumptions could increase portfolio NAV. Typed configuration parsing now rejects fractional or boolean session counts, validates supported rebalance schedules and ADV/warmup limits, parses explicit true/false strings, and checks finite nonnegative costs and valid broker participation limits.
Both direct dataclass construction and dictionary-based entry points share the validation. Integer text settings remain supported. A fill regression proves that disabling fractional shares actually produces an integer fill.
Validation: all 1,267 tests pass locally, including the full research pipeline and API integration, with 96% line coverage. The 48 targeted backtest/broker/cost tests include 24 new regression cases and an additional integer-text compatibility check. Ruff, formatting, mypy (63 source files), documentation navigation and diff checks pass. GitHub's Python 3.10–3.12 test jobs and documentation build also pass; the full integration result is tracked by the PR's CI checks.