Fail closed on SQLite snapshot sidecars - #1
Merged
Conversation
lukisch
force-pushed
the
agent/cleanup-sqlite-push-sidecars
branch
from
July 30, 2026 06:16
2eaabce to
2e6065b
Compare
lukisch
marked this pull request as ready for review
July 30, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DELETEjournal mode before redaction, scanning, verification, hashing, and publicationSyncConfig.from_bytes(payload, source_path=...);from_file()delegates to it so callers can hash and parse the exact same bytes without parallel config semanticsRoot cause
SQLite's backup API preserves the source database's persistent WAL journal mode. Later operations on the temporary backup could therefore create
.partial-waland.partial-shmfiles. The old cleanup removed only the main.partialfile, so sidecars survived both successful publication and error paths.Impact
A pushed transit now contains exactly one closed snapshot plus its manifest. Unmanifested SQLite sidecars fail closed and are removed. WAL source data remains included through SQLite's online backup API; no live database files are copied.
Validation
python -m unittest discover -s tests -v— 26 passedpython -m pytest -q— 26 passedpython -m ruff check sqlite_transit_sync tests— passedpython -m compileall -q sqlite_transit_sync tests— passedpython -m sqlite_transit_sync --help— passedgit diff --check— passedRegression coverage includes WAL-backed success, credential-scanner failure, forced quick-check failure, manifest plus manifest-temp failure, backup failure, and an unknown future sidecar suffix. All tests use synthetic temporary databases; no live data is involved.