BUGFIX: fix the UID update logic - #1290
Open
dwalter-bachmann wants to merge 1 commit into
Open
Conversation
The current logic matches wrongly matches usernames which only contain the string defined as the remote user. (eg: foo-admin matches for admin). This leads to duplicates UIDs being used unexpectedly. Steps to reproduce the issue: - Add a user `foo-admin` using eg: `RUN useradd -M foo-admin` - Add a second user (the expected remote_user) called `admin` via `RUN useradd admin` - Set the `remote_user` to `admin` in your devcontainer.json - Before applying the fix both users will have the same updated UID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic matches wrongly matches usernames which only contain the string defined as the remote user. (eg: foo-admin matches for admin). This leads to duplicates UIDs being used unexpectedly.
Steps to reproduce the issue:
foo-adminusing eg:RUN useradd -M foo-adminadminviaRUN useradd adminremote_usertoadminin your devcontainer.json