Support container CLI argument prefixes - #1291
Open
Gordon Lam (yeelam-gordon) wants to merge 2 commits into
Open
Support container CLI argument prefixes#1291Gordon Lam (yeelam-gordon) wants to merge 2 commits into
Gordon Lam (yeelam-gordon) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8539f306-93c4-4831-9bcd-ec77196d5ec8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8539f306-93c4-4831-9bcd-ec77196d5ec8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dev Containers can substitute a Docker-compatible executable such as
wslc, but app-owned WSLC Sessions require--session <name>before ordinary Docker-shaped commands. The CLI therefore needs a small transport mechanism for placing provider-specific arguments immediately after the configured Docker executable.Minimal design
--docker-path-argsoption containing a JSON string array.devcontainer.jsonschema or public configuration surface.Why not environment variables
A provider may not expose an environment-variable mechanism, while explicit argv is auditable at process boundaries and keeps the transport contract visible to the embedding caller.
Scope
This change defines only a CLI transport contract. It contains no WSLC-specific behavior or UI.
Tests run
npm run type-checkdockerUtilstests covering prefix ordering, Compose, and parsingnpm run lintcompile-prodDesign considerations and risks
The option is hidden and internal rather than a public compatibility promise. Parsing is strict so malformed input fails explicitly. Upstream consumers must package a matching CLI revision before relying on the argument contract.