perf: delete unnecessary commands#1827
Open
Runrioter wants to merge 3 commits intodevcontainers:mainfrom
Open
Conversation
Runrioter
commented
Apr 10, 2026
Author
Runrioter
left a comment
Runrioter
left a comment
There was a problem hiding this comment.
@microsoft-github-policy-service agree
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant Subversion upgrade/build step from the typescript-node devcontainer image build, likely because the typescript-node image is now layered on javascript-node, which already carries the Subversion CVE fix.
Changes:
- Deleted the
install-subversion.shscript that downloaded/built Subversion 1.14.5 from source. - Removed the Dockerfile steps that copied/executed that script during image build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/typescript-node/.devcontainer/scripts/install-subversion.sh |
Removes the custom Subversion 1.14.5 build/install script. |
src/typescript-node/.devcontainer/Dockerfile |
Stops invoking the deleted script during the image build. |
Author
|
@microsoft-github-policy-service agree |
Kaniska244
approved these changes
Apr 20, 2026
Contributor
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
To be further reviewed by maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete unnecessary commands. Because it depends on
javascript-nodewhich already fixes vulnerability issue