Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the public JS/Rust search contract before implementation: original comparisons remain intact, identical content has one shared source, and display selects sides independently. Then show the real top-level API usage with an unfiltered pretty-output fixture.
Review order: #6 → #7 → #20 → #8 → #10 → #13.
Read commit by commit:
0eebc6bb4— Define complete search comparisons and the code-mode API.86dbee35f— Specify search behavior with unfiltered pretty-printed output.Verification: the complete rewritten diffr tip has exactly the same Git tree as the previously tested tip (262 Rust tests passed, one ignored; 11 JS tests passed; TypeScript checks and the real pretty-output contract passed). No behavior changes in this rewrite.
This history is organized by API boundaries. Intermediate contract/usage commits may intentionally precede their implementations and need not compile individually.
AI assistance: authored and reorganized with Codex.