Conversation
sidkmenon
added this pull request to stack #496
September 23, 2026 17:40
sidkmenon
marked this pull request as ready for review
September 23, 2026 17:41
thesiti92
approved these changes
Sep 23, 2026
sidkmenon
added a commit
that referenced
this pull request
Sep 23, 2026
Restore the repository exactly to `5d5181f252011727621013b44a0f4cffeafaa5cf`, before the Whiteboard rename stack, so the user-facing rename can be rebuilt separately with a narrower scope. This reverts #478, #479, #480, #481, #482 and the subsequently merged #475, #494, #495. No branding, migrations, or later fixes are selectively retained; reapplication belongs in follow-up PRs. No new release was cut from these changes. Validation: the resulting Git tree is identical to the target commit (`a6e9beb4849072e538563e89449422f690c57fd8`), and the working tree is clean. The target tree previously passed [Review Desktop CI](https://github.com/devdotfast/review/actions/runs/35859829627). Tests have not been rerun locally; this PR will run CI again.
sidkmenon
added a commit
that referenced
this pull request
Sep 23, 2026
Applying a review lens could hide enclosing function context intentionally retained by diffr. Carry syntax scope boundaries through the structural provider and retain the visible context surrounding selected code, without expanding collapsed provider regions. Reapplies #495 after the rollback using existing Review paths and imports. Validation: all 23 existing lens and structural-diff tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whiteboard lenses can hide enclosing function context that diffr deliberately retained. Carry context scope boundaries through the structural diff provider and retain visible context around selected code without expanding through collapsed provider regions.
Complements devdotfast/diffr#34: that change improves the context emitted by diffr; this change preserves it when Whiteboard applies a lens.
Validation: all 23 existing lens and structural-diff tests pass.