Reduce the update zip listing before it crosses execFileSync's buffer - #551
Merged
Merged
Conversation
assertZipFolder listed every entry of the update zip through execFileSync, and the packaged app's listing is over a megabyte, so the first preview run after #549 died with spawnSync unzip ENOBUFS. Cut the listing down to its distinct top-level names in the shell instead. Agent-Session: 78ffd160-974b-41b4-b7dd-d536de7c2833 Agent-Session: f1eb7ebd-a71b-44e2-8563-daff06cc220e Agent-Session: aad32659-bbbe-45b2-b163-317afc1a6a83
sidkmenon
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertZipFolderfrom #549 piped the wholeunzip -Z1listing throughexecFileSync, whose default buffer is 1 MB; the packaged app's listing is larger, so preview run 35956033252 failed its Validate release artifacts step withspawnSync unzip ENOBUFS.Reduce the listing to its distinct top-level names in the shell (
cut | sort -u) before it reaches Node.Validation: dry run on a fake bundle with 40k files (5.8 MB listing) passes for the right folder and rejects the wrong one; script tests pass;
pnpm lintandoxfmtclean.