Add a macOS update smoke workflow that proves in-place updates keep the bundle name - #569
Merged
Merged
Conversation
…he bundle name Agent-Session: aad32659-bbbe-45b2-b163-317afc1a6a83 Agent-Session: cf02d6cd-2f50-4ed5-b0b8-df57e290e0a2 Agent-Session: 577bd1f2-c6f8-4b3a-a874-8dcb3eec6ed9 Agent-Session: f1eb7ebd-a71b-44e2-8563-daff06cc220e Agent-Session: 7f5dfda4-0600-4660-8e55-49a531e0c793
sidkmenon
approved these changes
Sep 24, 2026
thesiti92
added a commit
that referenced
this pull request
Sep 24, 2026
Reverts #569. The job did its work from a branch: run 36014912291 updated a .59 `Review Preview.app` and a .59 `Whiteboard Preview.app` to .66 in place on macOS runners, both keeping their folder names with ShipIt reporting a clean install. The workflow only needed to exist on main so a branch dispatch could run it; it is not meant to stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squirrel can't run in a Linux container, so the end-to-end check for #549/#553 needs a Mac. This adds a dispatchable workflow that does it on a GitHub macOS runner instead of someone's machine.
update-smoke.sh <quality> <from-version> <Review|Whiteboard>downloads that update zip, runs the app from a throwaway folder with isolated state, waits for Squirrel to stage the channel's current release, quits, and asserts the bundle kept its folder name, carries the new version, and ShipIt reported success. The workflow runs one job per zip, so a pre-rename (Review…app) and a renamed (Whiteboard…app) install are both covered, each on its own runner since Squirrel state is keyed by bundle id. App and installer logs are uploaded either way.Not runnable until it lands on main (
workflow_dispatchneeds the default branch). First run planned:quality=preview,from_version=0.0.34-preview.20260924.59against the current .66.