Conversation
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: e8a1eaea-7717-48b1-a143-d9adbd3f5f58 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: e8a1eaea-7717-48b1-a143-d9adbd3f5f58 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: e8a1eaea-7717-48b1-a143-d9adbd3f5f58 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: e8a1eaea-7717-48b1-a143-d9adbd3f5f58 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: e8a1eaea-7717-48b1-a143-d9adbd3f5f58 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400 Agent-Session: 0b48503e-b517-4f1d-a168-e843dc788525 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400 Agent-Session: 0b48503e-b517-4f1d-a168-e843dc788525 Agent-Session: 01a0e553-25fc-7350-ab29-e046a939a2e6
Agent-Session: 11e6cdc4-ebab-4f67-9499-a7e914620a86 Agent-Session: b11edf22-6b82-42e6-87c4-07c995cb9400 Agent-Session: d206e73a-3115-47e6-8c72-b8251090e94a Agent-Session: 01a0e5ab-8d00-7bd2-9d87-a0496098a08c
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a signed, notarized, auto-updating Whiteboard build for Intel Macs (
darwin-x64), alongside the Apple silicon build. Closes #614.How it builds
darwin-payload.tar.zst.buildjob is a matrix.darwin-arm64runs onmacos-15-xlargewith a 90-minute timeout.darwin-x64runs natively onmacos-15-large, the Intel larger runner, with a 150-minute timeout.darwin-arch.sh,darwinTarget()) instead of hardcodingdarwin-arm64.publish-macosjob, which needs the whole matrix.latest.jsonfiles last.finalize-releaseandtag-previewnow wait onpublish-macos.darwin) and the Intel DMG alias.Wrong-arch guard
validate-release-artifacts.mjsnow runslipo -archson the app executable, the bundled diffr, and every native executable declared by a bundled curated extension (currently ty and ruff).Dependencies (already live)
x86_64-apple-darwin(Build diffr for Intel Macs diffr#40, Backport VS Code security and reliability fixes #41, Prewarm tutorial reviews without blocking open #42), and this PR bumps to it.darwinfeed id toupdate/<channel>/darwin-x64/latest.json(Fix-Fast/dev#1102). It is deployed, and it answers 204 until the first Intel release.Worth knowing
darwin, so it keeps getting Intel updates. This is correct; please don't "fix" it.darwin-x64VSIX from upstream ships an arm64-onlynetcoredbg. C# debugging won't work on Intel Macs. It is not arch-asserted, on purpose.publish-linuxandpublish-windowsnow run in parallel withpublish-macos. Before, they started only after the Mac publish.curated-extensions.test.mjs, where it grepped script source text:$DARWIN_PAYLOAD_CURATED_EXTENSIONS_PATHordering check;--target=darwin-arm64incompile-darwin-payload.sh;target: "darwin-arm64"invalidate-release-artifacts.mjs, andREVIEW_DESKTOP_CURATED_EXTENSION_TARGET=darwin-arm64incompile-darwin-payload.sh.Tell me if any should be replaced with a behavioral test.
macos-darwin-arm64/macos-darwin-x64, instead ofreview-desktop-preview-<v>-dmg.Verification
node --test apps/review-desktop/scripts/*.test.mjspasses, apart from the existingyazlbaseline failure.actionlint, root lint and format are clean.