Skip to content

fix : fix newsletter omitting some props in ssr#272

Merged
timothygachengo merged 1 commit into
mainfrom
fix/fix-newsletter
Jul 23, 2026
Merged

fix : fix newsletter omitting some props in ssr#272
timothygachengo merged 1 commit into
mainfrom
fix/fix-newsletter

Conversation

@timothygachengo

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (BREAKING CHANGE:)
  • Refactor / chore (refactor: / chore:)
  • Documentation update (docs:)

Affected package(s)

  • @devgateway/dvz-ui-react
  • @devgateway/wp-react-lib
  • example only (no changeset needed)

Checklist

  • PR title follows Conventional Commits format
  • A changeset has been added (pnpm changeset) for any change to a published package
  • pnpm build passes locally
  • pnpm --filter @devgateway/* typecheck passes
  • No hardcoded credentials, internal URLs, client names, or PII introduced
  • Any new dependency has an Apache-2.0-compatible license

@pkg-pr-new

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@devgateway/dvz-ui-react@4830cdd
pnpm add https://pkg.pr.new/@devgateway/wp-react-lib@4830cdd

commit: 4830cdd

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the newsletter embeddable’s SSR prop parsing by accepting list/tag from either data-* attributes or plain React props, and avoids sending undefined values in the submit payload.

Changes:

  • Accept list/tag via both "data-list"/"data-tag" and list/tag props.
  • Build a submit payload that only includes list/tag when present.
  • Simplify button click handler by passing submit directly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/dvz-ui/src/embeddable/newsletter/index.jsx Expands prop parsing for SSR and adjusts submit payload construction/click handling.
.changeset/pink-adults-turn.md Adds a patch changeset entry describing the SSR props parsing fix.

Comment thread packages/dvz-ui/src/embeddable/newsletter/index.jsx
@timothygachengo
timothygachengo merged commit 5ba8c21 into main Jul 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants