fix : fix newsletter omitting some props in ssr#272
Merged
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the newsletter embeddable’s SSR prop parsing by accepting list/tag from either data-* attributes or plain React props, and avoids sending undefined values in the submit payload.
Changes:
- Accept
list/tagvia both"data-list"/"data-tag"andlist/tagprops. - Build a submit payload that only includes
list/tagwhen present. - Simplify button click handler by passing
submitdirectly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dvz-ui/src/embeddable/newsletter/index.jsx | Expands prop parsing for SSR and adjusts submit payload construction/click handling. |
| .changeset/pink-adults-turn.md | Adds a patch changeset entry describing the SSR props parsing fix. |
ralvarez-dg
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses