Polish Sources history loading, navigation, and thumbnails - #103
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Recent sources displays plain loading text while the rest of the dashboard uses skeletons. Clicking Sources in the sidebar also leaves the last inspector open, and video links look like search queries in the recent list.
What changed
History loading now uses skeleton rows with the dashboard's existing bars and pulse styling. Cached entries stay visible during refresh. Sources and Agent now share the same text-only empty history presentation, with matching typography and spacing. Sources directs new users to search for a topic or paste a link above. Session search appears only once sessions exist. It remains available when a search finds no matches, so users can revise their query.
Clicking Sources opens the input and recent list. It clears the displayed query or inspector and cancels its outstanding browser request. Ordinary navigation away from Sources still allows background requests to finish. Modified clicks keep their usual browser behavior.
Inspected links display thumbnails from saved metadata. Search entries keep their search icon. Both occupy matching 64-by-36-pixel tiles. Missing images use a YouTube fallback.
Existing history entries resolve their thumbnail from the shared asset reference on their first list read. The user DO caches only the URL reference, without copying image bytes or changing history order.
Tests
Both builds passed. All 40 dashboard browser cases passed, including desktop navigation and mobile light/dark layout checks. Nine user DO integration tests, 17 API/schema tests, and 81 web tests passed. The empty-state refinement also passed the web production build and all 11 focused Sources browser cases, including matching empty-state styles and mobile layout. The session-search refinement passed the web build and three browser cases covering empty accounts and searches with no matches. Documentation and diff checks passed.
Compatibility and deployment
Deploy platform and web changes together. Existing history remains usable. No bindings or schema migration are required. Preview and deployment verification remain pending.