Fix Sources caption handling, retries, and thumbnails - #104
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Videos without captions can show “YouTube is temporarily unavailable” and offer ineffective retries. Earlier proxy outages can mask confirmed absence. Retry controls lack dashboard styling, and thumbnails overflow their tiles.
What changed
Confirmed caption absence returns non-retryable
CAPTIONS_UNAVAILABLEafter successful, playable metadata checks. Bot challenges, rate limits, malformed responses, and missing requested languages retain their existing classifications.Sources displays “No captions available”, including after restoration, and excludes confirmed absence from retries. Retries use styled buttons and skeletons with cancellation. Transcripts remain visible during ordinary refreshes. Thumbnails fill their 64-by-36-pixel tiles with a centered crop.
Library version 0.6.3 is published. The platform, processor container, and frame container now pin that release with updated lockfiles.
Caption extraction is retained; confirmed absence replaces the generic error and retry path.
Tests
Platform build, 819 unit tests, 38 processor tests, and 16 frame-container tests passed. A regression test verifies terminal caption absence through the installed npm package. Frame extraction builds and storyboard bundle verification passed.
Earlier library, web, browser, documentation, skill bundle, and packed CommonJS/ESM checks passed. Docker builds remain unverified because the local daemon is unavailable.
Compatibility and deployment
Deploy platform and web together to activate the fixes and updated container dependencies. Confirmed caption absence gains a distinct API error code. No storage migration is required. Live verification of the supplied video remains pending deployment.