fix: wsman explorer calls for CIRA enabled device#1138
Open
DevipriyaS17 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 43.80% 44.21% +0.40%
==========================================
Files 144 144
Lines 13666 13695 +29
==========================================
+ Hits 5987 6055 +68
+ Misses 7112 7072 -40
- Partials 567 568 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes AMT Explorer WSMAN failures for CIRA-enrolled devices by routing explorer WSMAN traffic through the existing CIRA/APF tunnel (consistent with the main WSMAN usecase), instead of always attempting a direct hostname connection.
Changes:
- Decrypt device password once up-front and reuse it for both CIRA and non-CIRA explorer connections.
- For CIRA-enrolled devices, fetch the APF tunnel connection entry and build WSMAN messages using the CIRA channel manager rather than
device.Hostname.
sudhir-intc
changed the title
sudhir-intc
approved these changes
Jul 17, 2026
sudhir-intc
left a comment
sudhir-intc
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Verified the changes with a CIRA Device and non-CIRA device connected to Console
Contributor
|
@DevipriyaS17 : Please update the description with the issue which is being fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WSMAN Explorer returns a 500 Internal Server Error for CIRA-enrolled devices when attempting to execute Explorer operations. The issue occurs because Explorer requests cannot reach devices connected through CIRA, while the same operations continue to work for non-CIRA devices.
Root Cause
The Explorer's WSMAN client always attempted to connect directly to the device hostname and did not use the existing CIRA APF tunnel. Since CIRA devices are only reachable through the APF tunnel, Explorer requests failed and resulted in 500 errors.
Fix
Updated the WSMAN Explorer to route WSMAN calls through the existing CIRA APF tunnel when the target device is CIRA-enrolled, matching the behavior already used by other WSMAN calls in the codebase. Direct hostname connections continue to be used for non-CIRA devices, so their behavior remains unchanged.
Output: