fix: nest Linux config under /etc/dmt-console/config#620
fix: nest Linux config under /etc/dmt-console/config#620madhavilosetty-intel wants to merge 2 commits into
Conversation
|
testing is done on linux
hspe@PG14PRLCSB03:~/deployment$ pkill -x dmt-console
hspe@PG14PRLCSB03:~/deployment$ ps aux | grep -i dmt
hspe 19714 0.0 0.0 9172 2356 pts/4 S+ 15:16 0:00 grep --color=auto -i dmt
hspe@PG14PRLCSB03:~/deployment$ find ~/.config/device-management-toolkit/
/home/hspe/.config/device-management-toolkit/
/home/hspe/.config/device-management-toolkit/config
/home/hspe/.config/device-management-toolkit/config/config.yml
/home/hspe/.config/device-management-toolkit/console.db
hspe@PG14PRLCSB03:~/deployment$ find /etc/dmt-console/
/etc/dmt-console/
/etc/dmt-console/config
/etc/dmt-console/config/config.yml
hspe@PG14PRLCSB03:~/deployment$ sudo dmt-uninstall
Remove configuration (/etc/dmt-console)? [y/N]: y
Also remove hspe's Console data (devices, profiles, database) at /home/hspe/.config/device-management-toolkit? [y/N]: y
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages will be REMOVED:
dmt-console*
0 upgraded, 0 newly installed, 1 to remove and 270 not upgraded.
After this operation, 132 MB disk space will be freed.
(Reading database ... 283927 files and directories currently installed.)
Removing dmt-console (1.0.0) ...
(Reading database ... 283917 files and directories currently installed.)
Purging configuration files for dmt-console (1.0.0) ...
dpkg: warning: while removing dmt-console, directory '/opt' not empty so not removed
Removed per-user Console data: /home/hspe/.config/device-management-toolkit
hspe@PG14PRLCSB03:~/deployment$
hspe@PG14PRLCSB03:~/deployment$ find ~/.config/device-management-toolkit/
find: ‘/home/hspe/.config/device-management-toolkit/’: No such file or directory
hspe@PG14PRLCSB03:~/deployment$ find /etc/dmt-console/
find: ‘/etc/dmt-console/’: No such file or directory |
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux installer/uninstaller flow to place the Console’s machine-wide configuration under /etc/dmt-console/config instead of under the application directory, and adjusts related scripts/docs to match.
Changes:
- Move initial generated
config.ymllocation to/etc/dmt-console/config/config.yml. - Update uninstall/purge behavior to also remove
/etc/dmt-consoleon purge and back it up on RPM removals when keeping config. - Refresh Linux installer README and helper CLIs (
dmt-configure,dmt-uninstall) to reference the new config location.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| installers/linux/scripts/postremove.sh | Purge now removes /etc/dmt-console in addition to the app dir. |
| installers/linux/scripts/postinstall.sh | Generates config in /etc/dmt-console/config; changes config file permissions. |
| installers/linux/README.md | Documents new config location and updated install/uninstall behavior. |
| installers/linux/bin/dmt-uninstall | Updates prompt/backups to operate on /etc/dmt-console. |
| installers/linux/bin/dmt-configure | Points reconfigure tool at /etc/dmt-console/config/config.yml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Though not related to this PR, any merges to the deployment repo needs to wait
The console sub-module and sample-ui sub-module in deployment repo does not point a commit from the main of the console and sample-ui repo, instead it point a branch created by mike
console: GitHub - device-management-toolkit/console at 9827f1807d419de476e26156408f337dd3846986 .
sample-ui: ci: ensures UI is present for building by rsdmike · Pull Request #593 · device-management-toolkit/de…
I do see following key issues in the branch which was committed through the PR# ci: ensures UI is present for building by rsdmike · Pull Request #593 · device-management-toolkit/de…
- There's a docs folder for the design in this repo, this is against the guideline which Mike had mentioned to not have design docs in the code repos.
- There are partial code changes related to the feature "Make rpc-go and config Downloadable from Console UI"
No description provided.