Skip to content

test: split Cloud and Console activation and deactivation coverage - #3468

Merged
lim-chris merged 2 commits into
mainfrom
lxy-activate-deactivate
Jul 28, 2026
Merged

test: split Cloud and Console activation and deactivation coverage#3468
lim-chris merged 2 commits into
mainfrom
lxy-activate-deactivate

Conversation

@lim-chris

Copy link
Copy Markdown
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

  • Refactors the RPC activation test into separate activation and deactivation test coverage for Cloud and Console deployments.
  • Splits shared RPC command helpers into rpc.helpers.ts.
  • Adds dedicated activation and deactivation entry specs with Cloud and Console implementations.
  • Updates RPC-Go v3 command handling:
    • uses --tls-tunnel only for Cloud activation on AMT <= 18;
    • removes the unsupported tunnel flag from Cloud deactivation.

Anything the reviewer should know when reviewing this PR?

Console Run: https://github.com/device-management-toolkit/e2e-testing/actions/runs/30246108743
Cloud Run: https://github.com/device-management-toolkit/e2e-testing/actions/runs/30240073255

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the RPC Cypress E2E coverage by splitting activation vs. deactivation and routing Cloud vs. Console implementations via thin entry specs, while centralizing shared rpc-go command/exec helpers into a dedicated module.

Changes:

  • Introduces rpc.helpers.ts to share rpc-go v3 command builders, exec retry logic, and AMT-info parsing across specs.
  • Splits activation/deactivation coverage into separate Cloud and Console spec files, with activation.spec.ts and deactivation.spec.ts acting as environment-based routers.
  • Updates rpc-go v3 flag handling: uses --tls-tunnel only for Cloud activation on AMT <= 18 and removes tunnel usage from Cloud deactivation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
cypress/e2e/integration/rpc/rpc.helpers.ts Adds shared rpc-go helpers/command builders used by activation and deactivation specs.
cypress/e2e/integration/rpc/deactivation.spec.ts Adds Cloud vs. Console routing entrypoint for deactivation coverage.
cypress/e2e/integration/rpc/cloud.deactivation.spec.ts Adds Cloud-specific deactivation tests using the new helper builders.
cypress/e2e/integration/rpc/console.deactivation.spec.ts Adds Console-specific deactivation tests using the new helper builders.
cypress/e2e/integration/rpc/cloud.activation.spec.ts Updates Cloud activation spec to use shared helpers and refines output assertions/negative test flow.
cypress/e2e/integration/rpc/console.activation.spec.ts Updates Console activation spec to use shared helpers and removes deactivation coverage from this file.
cypress/e2e/integration/rpc/activation.spec.ts Converts activation entry spec into a router, but currently missing the required file header.

Comment thread cypress/e2e/integration/rpc/activation.spec.ts
Comment thread cypress/e2e/integration/rpc/rpc.helpers.ts
Comment thread cypress/e2e/integration/rpc/cloud.deactivation.spec.ts Outdated
Comment thread cypress/e2e/integration/rpc/console.deactivation.spec.ts Outdated
Comment thread cypress/e2e/integration/rpc/cloud.activation.spec.ts
@lim-chris
lim-chris force-pushed the lxy-activate-deactivate branch from 2463c1c to 8df5cd9 Compare July 27, 2026 08:08
@lim-chris lim-chris changed the title test(rpc): split Cloud and Console activation and deactivation coverage test: split Cloud and Console activation and deactivation coverage Jul 27, 2026
@lim-chris
lim-chris force-pushed the lxy-activate-deactivate branch 2 times, most recently from 191ce0c to d29c354 Compare July 27, 2026 08:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Comment thread cypress/e2e/integration/rpc/deactivation.spec.ts
Comment thread cypress/e2e/integration/rpc/cloud.deactivation.spec.ts
Comment thread cypress/e2e/integration/rpc/activation.spec.ts
Comment thread cypress/e2e/integration/rpc/rpc.helpers.ts
@lim-chris
lim-chris requested a review from choonkeat1986 July 27, 2026 14:43
@lim-chris
lim-chris merged commit 8e04146 into main Jul 28, 2026
10 checks passed
@lim-chris
lim-chris deleted the lxy-activate-deactivate branch July 28, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants