test: split Cloud and Console activation and deactivation coverage - #3468
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the RPC Cypress E2E coverage by splitting activation vs. deactivation and routing Cloud vs. Console implementations via thin entry specs, while centralizing shared rpc-go command/exec helpers into a dedicated module.
Changes:
- Introduces
rpc.helpers.tsto share rpc-go v3 command builders, exec retry logic, and AMT-info parsing across specs. - Splits activation/deactivation coverage into separate Cloud and Console spec files, with
activation.spec.tsanddeactivation.spec.tsacting as environment-based routers. - Updates rpc-go v3 flag handling: uses
--tls-tunnelonly for Cloud activation on AMT <= 18 and removes tunnel usage from Cloud deactivation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cypress/e2e/integration/rpc/rpc.helpers.ts | Adds shared rpc-go helpers/command builders used by activation and deactivation specs. |
| cypress/e2e/integration/rpc/deactivation.spec.ts | Adds Cloud vs. Console routing entrypoint for deactivation coverage. |
| cypress/e2e/integration/rpc/cloud.deactivation.spec.ts | Adds Cloud-specific deactivation tests using the new helper builders. |
| cypress/e2e/integration/rpc/console.deactivation.spec.ts | Adds Console-specific deactivation tests using the new helper builders. |
| cypress/e2e/integration/rpc/cloud.activation.spec.ts | Updates Cloud activation spec to use shared helpers and refines output assertions/negative test flow. |
| cypress/e2e/integration/rpc/console.activation.spec.ts | Updates Console activation spec to use shared helpers and removes deactivation coverage from this file. |
| cypress/e2e/integration/rpc/activation.spec.ts | Converts activation entry spec into a router, but currently missing the required file header. |
lim-chris
force-pushed
the
lxy-activate-deactivate
branch
from
July 27, 2026 08:08
2463c1c to
8df5cd9
Compare
lim-chris
force-pushed
the
lxy-activate-deactivate
branch
2 times, most recently
from
July 27, 2026 08:15
191ce0c to
d29c354
Compare
lim-chris
force-pushed
the
lxy-activate-deactivate
branch
from
July 27, 2026 08:35
d29c354 to
7c919a6
Compare
choonkeat1986
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
rpc.helpers.ts.--tls-tunnelonly for Cloud activation on AMT <= 18;Anything the reviewer should know when reviewing this PR?
Console Run: https://github.com/device-management-toolkit/e2e-testing/actions/runs/30246108743
Cloud Run: https://github.com/device-management-toolkit/e2e-testing/actions/runs/30240073255
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )