fix: add proxy configuration selector - #3470
Open
nbmaiti wants to merge 1 commit into
Open
Conversation
Proxy config name can be selected from dropdown Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AMT profile detail UI to allow selecting proxy configurations from a dropdown, and makes proxy configurations available in enterprise mode (when the backend returns them) rather than limiting them to cloud mode only.
Changes:
- Fetch proxy configs during profile-detail initialization for both cloud and enterprise.
- Replace the proxy config autocomplete input with a
<mat-select>dropdown and prevent re-selecting already-associated configs. - Add
isProxyProfileSelectedand extend unit tests for enterprise visibility and selection state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/profiles/profile-detail/profile-detail.component.ts | Fetch proxy configs unconditionally, broaden selectProxyProfile to accept string values, and add selection-state helper. |
| src/app/profiles/profile-detail/profile-detail.component.html | Switch proxy selection UI from autocomplete to a dropdown selector. |
| src/app/profiles/profile-detail/profile-detail.component.spec.ts | Add unit tests for enterprise proxy selector visibility and selected-state helper behavior. |
Comment on lines
540
to
543
|
|
||
| this.proxyAutocomplete.patchValue('') | ||
| } | ||
|
|
Comment on lines
+944
to
+949
| it('should mark an associated proxy configuration as selected', () => { | ||
| component.selectedProxyConfigs.set([{ priority: 1, name: 'proxy1' }]) | ||
|
|
||
| expect(component.isProxyProfileSelected('proxy1')).toBeTrue() | ||
| expect(component.isProxyProfileSelected('proxy2')).toBeFalse() | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: Issue #3469
Proxy config name can be selected from dropdown
PR Checklist
What are you changing?
Get available proxies, use them in drop down menu
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )