Add --wda-bundle-id flag for custom WDA bundle identifier#48
Open
Add --wda-bundle-id flag for custom WDA bundle identifier#48
Conversation
Enable --parallel N for the Appium driver. All N sessions hit the same Appium URL with identical capabilities — the server (local or cloud) allocates devices. Cloud providers (Sauce Labs, BrowserStack) get per-session result reporting. Changes: - determineExecutionMode: generate virtual IDs for Appium (like browser) - createAppiumWorkers: create N sessions against same URL - executeAppiumParallel: orchestrate workers via existing ParallelRunner - Per-worker cloud provider detection and reporting - Remove "parallel not yet supported" error for Appium
Don't create more Appium sessions than there are flows to run. With --parallel 3 and 2 flows, only 2 sessions are created instead of wasting a third device.
Allow users to specify a custom WDA bundle ID for code signing on iOS. When provided, PRODUCT_BUNDLE_IDENTIFIER is passed to xcodebuild, overriding the default com.facebook.WebDriverAgentRunner. Build cache includes the bundle ID to avoid collisions between different configs. Closes #41 Reported-by: Ma-Jiehui <https://github.com/Ma-Jiehui>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--wda-bundle-idCLI flag to specify a custom WDA bundle identifier for code signing on iOSPRODUCT_BUNDLE_IDENTIFIERis passed to xcodebuild, overriding the defaultcom.facebook.WebDriverAgentRunnerMAESTRO_WDA_BUNDLE_IDenvironment variableUsage
Test plan
go build ./...passesgo test ./pkg/driver/wda/... ./pkg/cli/...passes--wda-bundle-id— 9/9 pass (uses cached default build)--wda-bundle-id com.devicelab.WebDriverAgentRunner— 9/9 pass (fresh build, separate cache)Closes #41
Thanks to @Ma-Jiehui for reporting this issue.