Replace @1password/op-js with the 1Password JavaScript SDK

.vscodeignore

@@ -10,7 +10,9 @@
 compile.ts
 coverage/
 jest.config.js
-node_modules/
+node_modules/**
+!node_modules/@1password/sdk/**
+!node_modules/@1password/sdk-core/**
 package-lock.json
 src/
 !src/op-vscode.code-snippets

README.md

@@ -1,15 +1,17 @@
 # 1Password for VS Code
 
-1Password for VS Code provides you with a set of tools to integrate your development workflow with 1Password, powered by the [1Password CLI](https://developer.1password.com/docs/cli).
+1Password for VS Code provides you with a set of tools to integrate your development workflow with 1Password, powered by the [1Password JavaScript SDK](https://github.com/1Password/onepassword-sdk-js).
 
 ## Quick start
 
 ⚡️ This quick start guide will get you up and running with the extension.
 
-1. **Set up the CLI** - v2.4.0 or greater of the 1Password CLI needs to be [installed on your system](https://developer.1password.com/docs/cli/get-started#install).
-2. **Enable biometric unlock** - You must have [biometric unlock](https://developer.1password.com/docs/cli/about-biometric-unlock) enabled. If you don't have a biometric device, you'll still be able to use your device user password.
-3. **Install the extension** - From the [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=1Password.op-vscode) or [GitHub](https://github.com/1Password/op-vscode/releases) install the latest version of the extension.
-4. **Follow the prompts** - You'll be prompted to choose a 1Password account and vault. Follow these prompts to finish setup of the extension.
+<!-- https://github.com/1Password/onepassword-sdk-js#option-1-1password-desktop-app -->
+1. **Install the desktop app** - Install the [1Password desktop app](https://1password.com/downloads/) and sign in to your account in the app.
+2. **Open Developer Settings** - Select your account or collection at the top of the sidebar, then navigate to **Settings > Developer**.
+3. **Enable integration** - Under Integrate with the 1Password SDKs, select **Integrate with other apps**.
+4. **Install the extension** - From the [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=1Password.op-vscode) or [GitHub](https://github.com/1Password/op-vscode/releases) install the latest version of the extension.
+5. **Follow the prompts** - You'll be prompted to choose a 1Password account and vault. Follow these prompts to finish setup of the extension.
 
 You're all set. Learn more about what the extension is capable of by checking out the [developer portal documentation](https://developer.1password.com/docs/vscode/).
 

compile.ts

@@ -34,7 +34,10 @@ if (existsSync(distPath)) {
 		entryPoints: [`${srcPath}/extension.ts`],
 		bundle: true,
 		platform: "node",
-		external: ["vscode"],
+		// The 1Password SDK ships a ~10MB WebAssembly core that it loads from
+		// disk at runtime (via __dirname), so it can't be bundled. Keep the SDK
+		// packages external and ship them in node_modules instead.
+		external: ["vscode", "@1password/sdk", "@1password/sdk-core"],
 		outfile: `${distPath}/extension.js`,
 		minify: isProd,
 		plugins: [createLoggerPlugin("extension")],

package.json

@@ -29,7 +29,8 @@
 		"test": "jest",
 		"typecheck": "tsc --noEmit",
 		"vscode:prepublish": "yarn build",
-		"watch": "yarn compile --watch"
+		"watch": "yarn compile --watch",
+		"package": "vsce package"
 	},
 	"keywords": [
 		"1password",
@@ -104,6 +105,7 @@
 						"order": 1,
 						"type": "boolean",
 						"default": true,
+						"markdownDeprecationMessage": "**Deprecated**: The 1Password SDK does not cache values, so this setting no longer has any effect.",
 						"markdownDescription": "Use CLI cache when performing operations. Learn more about [caching](https://developer.1password.com/docs/cli/reference#cache-item-and-vault-information)."
 					},
 					"1password.items.passwordRecipe": {
@@ -158,7 +160,7 @@
 		]
 	},
 	"dependencies": {
-		"@1password/op-js": "^0.1.13",
+		"@1password/sdk": "^0.4.0",
 		"json-to-ast": "^2.1.0",
 		"open": "^8.4.0",
 		"timeago.js": "^4.0.2",
@@ -173,6 +175,7 @@
 		"@types/uuid": "^9.0.1",
 		"@types/vscode": "^1.66.0",
 		"@typescript-eslint/eslint-plugin": "^7.10.0",
+		"@vscode/vsce": "2.25.0",
 		"cross-env": "^7.0.3",
 		"esbuild": "^0.21.3",
 		"esbuild-register": "^3.5.0",
@@ -188,5 +191,8 @@
 		"typescript": "^5.4.5",
 		"uuid": "^9.0.0",
 		"yaml": "^2.3.1"
+	},
+	"resolutions": {
+		"cheerio": "^0"
 	}
 }