Fix plot_perturbation to ensure nbl is not plotted #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix plotting of nbl
EdCaunt
reviewed
Dec 1, 2025
Contributor
EdCaunt
left a comment
EdCaunt
left a comment
There was a problem hiding this comment.
Minor comment, but generally a useful fix. Thanks!
| dv = np.transpose(model.vp.data) - np.transpose(model1.vp.data) | ||
| slices = tuple(slice(model.nbl, -model.nbl) for _ in range(2)) | ||
| slices1 = tuple(slice(model1.nbl, -model1.nbl) for _ in range(2)) | ||
| dv = np.transpose(model.vp.data[slices]) - np.transpose(model1.vp.data[slices1]) |
Contributor
There was a problem hiding this comment.
I would personally check model.nbl == model1.nbl and raise a suitable ValueError if not (probably also check the size of both models match whilst you're at it).
That way you only need a single slices which would be tidier and easier to read in my opinion.
Minor note, you can also do slices = (slice(model.nbl, -model.nbl),) * 2 for concision, although this is arguably less explicit. A matter of personal preference I would say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plot_perturbationhas a small bug where the nbl is not properly addressed when plotting. This PR addressed that by applying the same slicing asplot_velocity.