Repository navigation
Publish the signed Apple Silicon disk image as an updater platform - #12
Merged
Merged
Conversation
In-app update looks up macos-aarch64 in latest.json and failed because that platform was missing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-aarch64. Release 6.2.74 uploaded the disk image, butlatest.jsononly listed Linux and Windows, so Check/Install failed with "the platform macos-aarch64 was not found in the response platforms object".BiFlow_<version>_aarch64.dmgwith the existing updater key and publishes that signature asplatforms["macos-aarch64"]. The key stays identical tosigned_targetfor a DMG onaarch64.mainpublishes a release whose manifest installed Apple Silicon builds can install. The already published 6.2.74 disk image has no signature, so that release cannot grow this platform after the fact.Test plan
node --test scripts/generate-latest-json.test.mjsassertsplatforms["macos-aarch64"]points atBiFlow_<version>_aarch64.dmgand matches the Rust updater targetscripts/build-plan.test.mjsrequires the release workflow to sign the disk image and upload*.dmg.sigcargo test -p iran-split-desktop --lib github_updateconfirms the Apple Silicon target ismacos-aarch64pnpm check,pnpm build, andcargo clippy -p iran-split-desktop --all-targets -- -D warningslatest.jsoncontainsmacos-aarch64with a signature, then install the update from an older Apple Silicon build via About → Check for updatesMade with Cursor