Own UI themes and paint caches explicitly - #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the overlay and About dialog independent resolved themes, and let the overlay retain its help-layout and radial-menu caches through explicit UI rendering contexts.
Preserve cache keys, scrolling behavior, matrix-derived density, and existing popup colors. Radial cache entries now compare theme values so reused surfaces cannot retain colors from another theme. Standalone rendering APIs retain their theme-initialization behavior, including returning from empty paints before initializing the legacy theme.
Add regressions for cache reuse and invalidation, independent owners, theme and density changes, help scrolling, themed status/zoom/About output, and standalone API compatibility.
Validation:
./tools/lint-and-test.shpasses with Rust 1.98.1, including formatting, workspace clippy, builds, and tests with all features and no default features.