Own text resources and clarify region selection state - #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactor replaces ambient text resources with explicit ownership and consolidates region-selection state.
No user-facing behavior change is intended.
Resource ownership
Runtime paths now reuse persistent
UiTextEngineandTextMeasurerowners. Standalone public convenience APIs remain available where practical and create one call-local owner per operation.This keeps mutable text caches isolated while avoiding repeated resource construction in internal loops.
Public API change
The ambient help hit-map functions were removed:
clear_help_overlay_hit_maphelp_overlay_region_atStandalone interactive callers should use
render_help_overlay_resultand query the returnedHelpRenderResult::hit_mapwithHelpHitMap::region_at.Region selection
The backend now owns the canonical selector lifecycle and geometry. Input state retains only a synchronized projection used for gating and painting.
The refactor preserves capture, OCR, measurement, review, cut editing, cancellation, stale-result rejection, and device ownership behavior.
Validation
Validated on Rust 1.98.1:
RUST_TEST_THREADS=1 ./tools/lint-and-test.sh-D warningsin both feature configurations