Centralize edit and workflow ownership; fix properties panel spacing - #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consolidates canvas edit transactions, configurator workflows, capture preflight state, and GTK popover resources under explicit owners. Selection previews and commits share snapshot/history handling; configurator document, migration, shortcut, and daemon phases own their transitions. Config save validation uses typed results, and command palette painting consumes a prepared view.
It also fixes properties-panel info text overlapping the title divider. Layout now positions the first info baseline below the title box using measured text ascent and supplies the divider coordinate to the renderer. Panel height and bottom padding stay unchanged. A regression test checks that info text clears both the divider and entry rows.
Validation:
./tools/lint-and-test.shpassed, including packaging and source audits, formatting, workspace Clippy, binary builds, and tests with all features and with default features disabled. No manual Wayland or GTK UI check was performed.The broader properties-panel visual suggestions (aligned info columns, swatches, unit formatting, focus insets, and overflow handling) are outside this fix.