Change GitHub Workflow to build containers#148
Open
ich777 wants to merge 3 commits into
Open
Conversation
- add build matrix - update build-push-action to v7
- whoopsie, only push images to ghcr on merge to main
- remove QEMU and also use matrix for runners - fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just made a few tweaks since I noticed you haven't got any pre built Docker images.
This change will basically build all Docker containers for all Dockerfiles in your project through GitHub workflows.
Please also don't forget to set the visibility form your Docker images to public, of course only if this PR is interesting and you are willing to merge it.
Do also note that I haven't changed the compose files yet since I wasn't too sure if you want to Merge that.
Cheers and keep up the good work,
Christoph