Update on main branch

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,7 +10,7 @@
 
 Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
 
-1. 
+1.
 
 ---
 
@@ -20,14 +20,16 @@ Make sure everything is checked before merging this PR. For further info please
 our [DoD](https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/DoD.adoc).
 
 - [ ] When running `mvn clean test` locally all tests pass and build is successful
-- [ ] PR title is of the form `#«issue-id»: «brief summary»` (e.g. `#921: fixed setup.bat` and not `feature/921 fixed setup.bat`). If no issue ID exists, title only.
-- [ ] PR top-level comment summaries what has been done and contains link to addressed issue(s)
+- [ ] PR title is of the form `#«issue-id»: «brief summary»` (e.g. `#921: fixed setup.bat` and not `feature/921 fixed setup.bat`).
+  If no issue ID exists, title only.
+- [ ] PR top-level comment summarizes what has been done and contains link to addressed issue(s)
 - [ ] PR and issue(s) have suitable labels
 - [ ] Issue is set to `In Progress` and assigned to you *or* there is no issue (might happen for very small PRs)
-- [ ] You followed all [coding conventions](https://github.com/devonfw/IDEasy/blob/main/documentation/coding-conventions.adoc)
+- [ ] You followed all [coding conventions](https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/coding-conventions.adoc)
 - [ ] You have added the issue implemented by your PR in [CHANGELOG.adoc](https://github.com/devonfw/IDEasy/blob/main/CHANGELOG.adoc) unless issue is labelled
   with `internal`
-- [ ] You have not changed any dependency in `pom.xml` files or otherwise if runtime dependencies changed, you have updated our [LICENSE.asciidoc](https://github.com/devonfw/IDEasy/blob/main/documentation/LICENSE.adoc)
+- [ ] You have not changed any dependency in `pom.xml` files or otherwise if runtime dependencies changed,
+  you have updated our [LICENSE.adoc](https://github.com/devonfw/IDEasy/blob/main/documentation/LICENSE.adoc)
 - [ ] You have formulated clear instructions on how to test your contribution under "Testing instructions"
 
 ### Checklist for tool commandlets
@@ -43,3 +45,10 @@ Have you added a new `«tool»` as commandlet? There are the following additiona
 - [ ] The variables `«TOOL»_VERSION` and `«TOOL»_EDITION` are honored by your commandlet
 - [ ] The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue
 
+### Checklist for GUI contributions
+
+Did you make user-facing changes to the GUI? There are the following additional checks:
+
+- [ ] You followed the [ui-contribution-process.adoc](https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/ui-contribution-process.adoc) and [ui-structure.adoc](https://github.com/devonfw/IDEasy/blob/main/documentation/contributing/ui-structure.adoc)
+- [ ] The UI changes are designed in the Figma project and the design was approved in the team review
+- [ ] You have added screenshots of the UI changes to the PR description

.github/workflows/assign-pr-author.yml

@@ -4,9 +4,6 @@ on:
   pull_request_target:
     types: [opened]
 
-env:
-  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
-
 permissions:
   contents: read
   pull-requests: write
@@ -15,6 +12,9 @@ permissions:
 jobs:
   assign-author:
     runs-on: ubuntu-latest
+    if: >
+      github.event_name == 'workflow_dispatch' ||
+      vars.ENABLE_AUTOMATIC_WORKFLOWS == 'true'
 
     steps:
       - name: Assign PR author if no assignee exists
@@ -24,16 +24,26 @@ jobs:
             const pr = context.payload.pull_request;
 
             // Do not overwrite existing assignees
-            if (pr.assignees && pr.assignees.length > 0) {
+            if (pr.assignees?.length > 0) {
               console.log('PR already has assignees. Skipping.');
               return;
             }
+            // Bot accounts cannot be assigned like regular contributors
+            if (pr.user.type === 'Bot') {
+              console.log(`PR author ${pr.user.login} is a bot. Skipping assignment.`);
+              return;
+            }
 
-            await github.rest.issues.addAssignees({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: pr.number,
-              assignees: [pr.user.login]
-            });
-
-            console.log(`Assigned ${pr.user.login} to PR #${pr.number}`);
+            try {
+              await github.rest.issues.addAssignees({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: pr.number,
+                assignees: [pr.user.login]
+              });
+
+              console.log(`Assigned ${pr.user.login} to PR #${pr.number}`);
+            } catch (err) {
+              // E.g. fork author is not a collaborator — don't fail the workflow
+              console.log(`Warning: could not assign ${pr.user.login}: ${err.message}`);
+            }

.github/workflows/build.yml

@@ -7,6 +7,8 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    if: >
+      ${{ github.event_name == 'workflow_dispatch' || vars.ENABLE_AUTOMATIC_WORKFLOWS == 'true' }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v7

.github/workflows/check-for-updates.yml

@@ -9,6 +9,9 @@ jobs:
   # Checks if new commits since 24 hours of the last call of this workflow were found and adjusts the GITHUB_OUTPUT accordingly
   verify_commit:
     runs-on: ubuntu-latest
+    if: >
+      github.event_name == 'workflow_dispatch' ||
+      vars.ENABLE_AUTOMATIC_WORKFLOWS == 'true'
     outputs:
       RUN_BUILD: ${{ steps.verify_commit.outputs.RUN_BUILD }}
     steps:

.github/workflows/ci-status-watch.yml

@@ -0,0 +1,126 @@
+name: CI status watch
+
+# Posts a Teams message listing the README badge workflows that are currently red on the
+# default branch. A workflow stays in the list until it is green again, so the reminder
+# repeats every weekday morning until somebody fixes it. Creates no issues, read-only.
+# If a status cannot be checked, Teams receives a warning to check it manually.
+# Requires the repository secret TEAMS_WEBHOOK_URL.
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 7 * * 1-5'   # 07:00 UTC, Mon-Fri (= 09:00 CEST / 08:00 CET)
+
+permissions:
+  actions: read
+
+jobs:
+  watch:
+    if: >
+      github.repository == 'devonfw/IDEasy' &&
+      (github.event_name == 'workflow_dispatch' || vars.ENABLE_AUTOMATIC_WORKFLOWS == 'true')
+    runs-on: ubuntu-latest
+    env:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      WEBHOOK: ${{ secrets.TEAMS_WEBHOOK_URL }}
+      REPO: ${{ github.repository }}
+      BRANCH: ${{ github.ref_name }}
+    steps:
+      - name: Check badge workflow status and notify Teams
+        run: |
+          set -euo pipefail
+
+          # The workflows backing the README badges. Add a line here if a badge is added.
+          WORKFLOWS="
+            .github/workflows/build.yml
+            .github/workflows/update-urls.yml
+            .github/workflows/nightly-build.yml
+            .github/workflows/integration-tests.yml
+          "
+
+          echo "Checking badge workflows on branch $BRANCH"
+
+          # Cancelled/skipped runs say nothing about the code and are ignored. A failed lookup
+          # is kept as an unknown status so Teams can ask the team to check it manually.
+          RESULTS=$(for WF_PATH in $WORKFLOWS; do
+              if RUNS=$(gh run list --repo "$REPO" --workflow "$WF_PATH" --branch "$BRANCH" \
+                --status completed --limit 5 --json conclusion,url,updatedAt,workflowName); then
+                echo "$RUNS" | jq --arg workflow "$WF_PATH" '
+                  ([ .[] | select(.conclusion != "cancelled" and .conclusion != "skipped") ][0]) as $run
+                  | if $run == null then
+                      {state: "unknown", workflow: $workflow}
+                    elif ($run.conclusion == "failure" or $run.conclusion == "timed_out"
+                      or $run.conclusion == "startup_failure") then
+                      {state: "red", name: $run.workflowName, url: $run.url, since: $run.updatedAt}
+                    else
+                      {state: "green", workflow: $workflow}
+                    end'
+              else
+                echo "Status lookup failed for $WF_PATH." >&2
+                jq -n --arg workflow "$WF_PATH" '{state: "unknown", workflow: $workflow}'
+              fi
+            done | jq -s '.')
+
+          RED=$(echo "$RESULTS" | jq '[.[] | select(.state == "red")]')
+          UNKNOWN=$(echo "$RESULTS" | jq '[.[] | select(.state == "unknown")]')
+          RED_COUNT=$(echo "$RED" | jq 'length')
+          UNKNOWN_COUNT=$(echo "$UNKNOWN" | jq 'length')
+          if [ "$RED_COUNT" -eq 0 ] && [ "$UNKNOWN_COUNT" -eq 0 ]; then
+            echo "No badge workflow is red. Skipping Teams notification."
+            exit 0
+          fi
+          echo "$RED_COUNT badge workflow(s) currently red; $UNKNOWN_COUNT status lookup(s) unknown."
+
+          if [ -z "${WEBHOOK:-}" ]; then
+            echo "No Teams webhook set; notification cannot be delivered."
+            exit 1
+          fi
+
+          CARD=$(jq -n \
+            --argjson red "$RED" \
+            --argjson unknown "$UNKNOWN" \
+            --argjson redCount "$RED_COUNT" \
+            --argjson unknownCount "$UNKNOWN_COUNT" \
+            --arg repo "$REPO" '
+            {
+              type: "AdaptiveCard",
+              "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
+              version: "1.4",
+              body: (
+                [
+                  { type: "TextBlock", size: "Large", weight: "Bolder", wrap: true,
+                    color: (if $redCount > 0 then "attention" else "warning" end),
+                    text: (if $redCount > 0 then "🔴 CI ist rot" else "⚠️ CI-Status unklar" end) }
+                ]
+                + (if $redCount > 0 then
+                    [ { type: "TextBlock", spacing: "None", isSubtle: true, wrap: true,
+                        text: (if $redCount == 1 then "1 Workflow ist rot" else "\($redCount) Workflows sind rot" end) } ]
+                    + [ $red[] | {
+                          type: "Container", separator: true, spacing: "Medium",
+                          items: [
+                            { type: "TextBlock", weight: "Bolder", wrap: true, text: "🔴 \(.name)" },
+                            { type: "TextBlock", spacing: "None", isSubtle: true, size: "Small", wrap: true,
+                              text: "rot seit \(.since) · [Run-Log öffnen](\(.url))" }
+                          ]
+                        } ]
+                  else [] end)
+                + (if $unknownCount > 0 then
+                    [
+                      { type: "TextBlock", weight: "Bolder", wrap: true, color: "warning",
+                        spacing: "Large", text: "⚠️ Statusprüfung unvollständig" },
+                      { type: "TextBlock", wrap: true,
+                        text: "Bitte den Status der folgenden Workflows manuell in GitHub prüfen." }
+                    ]
+                    + [ $unknown[] | {
+                          type: "TextBlock", wrap: true,
+                          text: "⚠️ [\(.workflow | split("/") | last)](https://github.com/\($repo)/actions/workflows/\(.workflow | split("/") | last))"
+                        } ]
+                  else [] end)
+              )
+            }')
+
+          curl -sS --fail -X POST -H "Content-Type: application/json" -d "$CARD" "$WEBHOOK"
+          if [ "$UNKNOWN_COUNT" -gt 0 ]; then
+            echo "At least one workflow status could not be checked."
+            exit 1
+          fi

.github/workflows/clean-runs.yml

@@ -6,6 +6,9 @@ on:
 jobs:
   del_runs:
     runs-on: ubuntu-latest
+    if: >
+      github.event_name == 'workflow_dispatch' ||
+      vars.ENABLE_AUTOMATIC_WORKFLOWS == 'true'
     steps:
       - name: Delete cancelled workflow runs
         uses: Mattraks/delete-workflow-runs@v2