Open
Conversation
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/cli/Ideasy.java
renamed TestLogger to IdeLoggerAdapter added missing param to javadoc renamed TestProvider to TestProviderImpl renamed TestLoggerFactory to TestLoggerFactoryImpl
added first implementations for IdeLoggerAdapter methods replaced IdeSubLoggerSlf4j with IdeSubLoggerOut
added null checks to IdeLoggerAdapter debug methods
added rest of null checks
Collaborator
Pull Request Test Coverage Report for Build 22345446363Details
💛 - Coveralls |
Member
Author
|
Further questions and ideas:
|
… version/edition list commandlets)
Member
Author
|
Tested with GraalVM and not working (as always nasty): |
Member
Author
|
GraalVM issues fixed and all tested locally. Works now. |
SDallmann
reviewed
Mar 3, 2026
|
|
||
| @Override | ||
| public void run() { | ||
| public boolean isWriteLogFile() { |
Contributor
There was a problem hiding this comment.
Verständnis-Frage: wofür wird isWriteLogFile() benutzt? (wenn es immer false zurück gibt)
SDallmann
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
I couldn't find any usage of this interface. Is it planned for use in the future, or YAGNI? :)
SDallmann
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
I couldn't find any usage of this class. Is it planned for use in the future, or YAGNI? :)
SDallmann
reviewed
Mar 4, 2026
| Throwable error = getError(); | ||
| if (error == null) { | ||
| this.context.success("You are online."); | ||
| IdeLogLevel.INTERACTION.log(LOG, "You are online."); |
Contributor
There was a problem hiding this comment.
Shouldn't this be IdeLogLevel.SUCCESS.log instead of IdeLogLevel.INTERACTION.log?
SDallmann
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
As this interface was deleted, our UML class diagram should be updated.
SDallmann
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
As this class was deleted, our UML class diagram should be updated
SDallmann
reviewed
Mar 4, 2026
Contributor
SDallmann
left a comment
SDallmann
left a comment
There was a problem hiding this comment.
Other than the comments that I've already posted, everything looks fine to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1713 and #404
Replacement of PR #1710
Implemented changes:
get()method.LevelandMarkerinstances in all ourIdeLogLevelconstants. TheMarkerisnullfor standard log-levels but used to express our custom log-levels via SLF4J API.JulLogLevelwith custom log levels for JUL for IDEasy log-levels.IdeLogLevelto allow conversions from/to SLF4J and JUL.IdeVariables.IDE_WRITE_LOGFILE.Slf4jLoggerAdaptercreatejava.util.logging.Loggerfor external loggers and useIdeLoggerfor internal ones and route log messages accordingly.LOGto every class that logs something and refactored log statements to thatLOG.IdeLogger*and*IdeSubLogger*Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal