Repository navigation
fix(admin): modal grande nao aplicava a largura no desktop - #55
Merged
Merged
Conversation
…CSS) O componente Dialog ja tem "sm:max-w-sm" embutido como classe base. O max-w-6xl que adicionei antes nao tinha o prefixo "sm:", entao a media query do componente ganhava a cascata em telas desktop e o modal continuava estreito. Corrige usando sm:max-w-6xl (mesmo prefixo), que o twMerge substitui corretamente pela classe base. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
No PR #54 alarguei os modais do admin pra max-w-6xl, mas continuaram estreitos no desktop. Causa: o componente Dialog ja tem "sm:max-w-sm" como classe base — sem o prefixo "sm:" na minha classe, a media query do componente ganhava a cascata CSS em telas >= 640px.
Fix
Troca max-w-6xl por sm:max-w-6xl (mesmo prefixo da classe base) nos 5 arquivos/7 modais, garantindo que o twMerge substitua corretamente a classe original em vez de deixar as duas competindo na cascata. Confirmado com teste direto do twMerge (a string final so contem sm:max-w-6xl, sem sm:max-w-sm).
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com