fix(auth,appstore): eliminate redundant query branches and optimize batch role lookups

[vjymisal0]

Summary of Changes

This PR optimizes role verification logic and adds batch user status filtering:

1. Refactored RBAC Role Check in UserCommonService.go:
   • Streamlined redundant conditional branching when verifying whether a role matches specified entity/action criteria.
   • Cleaned up duplicate mapping lookups for admin and manager role validations.
2. Batch User Filtering in UserRepository.go:
   • Added FilterActiveUserIds helper to batch-filter active users in-memory from user models, avoiding unnecessary round-trips.
3. Comprehensive Unit Tests:
   • Added pkg/auth/user/UserCommonService_test.go to test role evaluation permutations.
   • Added pkg/auth/user/repository/UserRepository_test.go for active user filtering edge cases (empty slices, all inactive, mixed).
   • Added pkg/appStore/installedApp/service/common/AppStoreDeploymentCommonService_test.go covering deployment validation helpers.

Files Changed

• pkg/auth/user/UserCommonService.go
• pkg/auth/user/repository/UserRepository.go
• pkg/auth/user/UserCommonService_test.go
• pkg/auth/user/repository/UserRepository_test.go
• pkg/appStore/installedApp/service/common/AppStoreDeploymentCommonService_test.go

[bito-code-review]

Bito Review Skipped - Source Branch Not Found

Bito didn't review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

[vjymisal0]

Removed the unused FilterActiveUserIds helper and its associated unit test in commit 12cb36e.

[vjymisal0]

Thanks for the review. I followed up on those points in commit 12cb36e727564194cf4adea8d0fbb7d4692da209: the unused FilterActiveUserIds helper and its associated test are removed, so the remaining diff is limited to the intended auth/appstore changes.

[vjymisal0]

Pushed the cleanup. The unrelated appstore helper test is gone now, and the unused FilterActiveUserIds helper/test were already removed in the previous update.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vjymisal0]

Reviewed the latest PR state and the available checks. SonarQube reports a passed quality gate with 0 new issues, 0 accepted issues, and 0 security hotspots. I did not make additional changes because no maintainer action was requested; the Bito review was skipped due to a source-branch lookup issue. A local Go test was not runnable because Go is not installed in this environment.