Skip to content

fix: PagerBug: API token Last Used On/By IP fields never update after use against Kubernetes resources (pager #2971) #7040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devtronpageragent wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Draft

fix: PagerBug: API token Last Used On/By IP fields never update after use against Kubernetes resources (pager #2971) #7040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/apiToken/ApiTokenService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,14 @@ func (impl ApiTokenServiceImpl) GetAllActiveApiTokens() ([]*openapi.ApiToken, er
apiToken.Token = &apiTokenFromDb.Token
}
if latestAuditLog != nil {
lastUsedAtStr := latestAuditLog.CreatedOn.String()
// the user_audit row is updated in place on every usage, so updated_on holds the latest usage;
// created_on only holds the first usage and is used as fallback for rows written before
// updated_on was added to user_audit
lastUsedAt := latestAuditLog.UpdatedOn
if lastUsedAt.IsZero() {
lastUsedAt = latestAuditLog.CreatedOn
}
lastUsedAtStr := lastUsedAt.String()
apiToken.LastUsedAt = &lastUsedAtStr
apiToken.LastUsedByIp = &latestAuditLog.ClientIp
}
Expand Down
Loading