Tuist example: bump SafeDI to 2.0.0-rc-2 + move CI to Xcode 26.0#293
Merged
Tuist example: bump SafeDI to 2.0.0-rc-2 + move CI to Xcode 26.0#293
Conversation
Now that 2.0.0-rc-2 is released with `swift-tools-version: 6.2`, the Tuist example's `Tuist/Package.swift` can resolve under Xcode 26.0 (Swift 6.2). Drop the carve-out in `spm-tuist-integration` and run on the same baseline as the rest of the SafeDI-core CI. - `Examples/ExampleTuistIntegration/Tuist/Package.swift`: SafeDI pin `from: "2.0.0-rc-1"` → `from: "2.0.0-rc-2"`. Package.resolved updated to match. - `Examples/ExampleTuistIntegration/README.md`: copy-paste snippet + `>= rc-1` reference both bumped to rc-2. - `.github/workflows/ci.yml`: `spm-tuist-integration` job switches to Xcode 26.0 and drops the comment explaining why we were stuck on 26.4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 7043 7043
=========================================
Hits 7043 7043 🚀 New features to boost your workflow:
|
2 tasks
dfed
added a commit
that referenced
this pull request
May 4, 2026
Mirrors what the `./.github/actions/retry` composite already does for `xcrun swift package resolve` / `xcrun xcodebuild -resolvePackageDependencies`: 6 attempts with exponential backoff (15s → 240s). ## Why Hit [a `502 Bad Gateway`](https://github.com/dfed/SafeDI/actions/runs/25341849272/job/74300849749) on `main`'s post-merge CI for [#293](#293). Bazel was fetching `MobileNativeFoundation/index-import/releases/download/6.1.0.1/index-import.tar.gz` (a transitive `rules_swift` dependency) and GitHub's CDN flaked. Our other download-flavored CI steps already wrap retry around it; the bazel job didn't. ## What changes - `.github/workflows/ci.yml` — both `bazelisk build` steps in the `bazel` job now go through `./.github/actions/retry`. - `Build Example`'s `working-directory: Examples/ExampleBazelIntegration` becomes a `cd …` inside the retry action's `command` (composite-action `uses:` ignores `working-directory`). ## Test plan - [x] Retry action's behavior unchanged from existing usage; new wiring is identical. - [ ] CI green on this PR's first run (no need to deliberately trigger a flake — the change just adds tolerance). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
2.0.0-rc-2is out withswift-tools-version: 6.2, the Tuist example'sTuist/Package.swiftcan resolve on Xcode 26.0 (Swift 6.2). Completes the matrix consolidation #292 deferred.Changes
Examples/ExampleTuistIntegration/Tuist/Package.swift— SafeDI pinfrom: "2.0.0-rc-1"→from: "2.0.0-rc-2".Examples/ExampleTuistIntegration/Tuist/Package.resolved— re-resolved against rc-2.Examples/ExampleTuistIntegration/README.md— copy-paste snippet +>= rc-1mention bumped to rc-2..github/workflows/ci.yml:spm-tuist-integrationswitches to Xcode 26.0 and drops the comment explaining the 26.4 carve-out.Test plan
swift package resolveagainst the new pin — pulls rc-2 + the correspondingSafeDITool.artifactbundle.zip../CLI/lint.shclean.spm-tuist-integration).🤖 Generated with Claude Code