Closed
Conversation
3 tasks
Contributor
chenyan-dfinity
left a comment
There was a problem hiding this comment.
This is a breaking change. It's quite labor intensive to bump the candid major version in the mono repo. So we try to avoid breaking changes as much as possible.
I can see two options: 1) we can let this PR to sleep for a while, until we make a major release (which can take quite a long time); 2) Candid error is not really structured. For the downstream users, it's enough to convert to err.to_string(), and clone as needed.
Contributor
Author
|
I agree that making a major bump just for this feature is not worth the effort, so I'm fine with leaving this to sleep and in the meantime I will just |
Contributor
|
In addition to the previous discussion, in Rust the errors are not typically clonable. Closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This makes
candid::Errorclonable, which makes it easier for downstream clients to also make theirErrortypes cloneable.I've made a related PR for agent-rs.
Considered Solutions
I can also work around by using
Arc<T>in downstream clients.Considerations
This shouldn't have any impact on security or performance. Anyone that was interacting directly with the
Customvariant may have a breaking change since it is wrapped in anArc<T>now.