Skip to content

test(minter): replace the stubbed runtime with a mockall mock of inter-canister calls #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gregorydemay wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test(minter): replace the stubbed runtime with a mockall mock of inter-canister calls #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86bd52a
test(minter): replace the stubbed runtime with a mockall mock of inte…
gregorydemay Oct 2, 2026
30a386a
test(minter): suspend mocked inter-canister calls before answering them
gregorydemay Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions minter/src/deposit/sweep/finalize/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async fn should_ask_for_another_round_only_after_crediting_with_sweeps_left_over
finalize_devnet_sweep();
let mut runtime = TestCanisterRuntime::new()
.with_increasing_time()
.add_stub_response(devnet_sweep_response);
.expect_get_transaction(devnet_sweep::transaction_signature(), devnet_sweep_response);
for index in 0..MAX_CONCURRENT_RPC_CALLS {
let deposit_id = (devnet_sweep::DEPOSITS.len() + index) as DepositSolId;
let account = account(deposit_id as usize + 1);
Expand All @@ -68,7 +68,10 @@ async fn should_ask_for_another_round_only_after_crediting_with_sweeps_left_over
);
succeed_transaction(sweep_signature);
if index + 1 < MAX_CONCURRENT_RPC_CALLS {
runtime = runtime.add_stub_response(GetTransactionResult::Consistent(Ok(None)));
runtime = runtime.expect_get_transaction(
sweep_signature,
GetTransactionResult::Consistent(Ok(None)),
);
}
}

Expand Down Expand Up @@ -96,7 +99,11 @@ async fn should_credit_the_amount_received_by_the_main_account() {
setup();
let sweep_signature = finalize_devnet_sweep();

credit_finalized_sweeps(&runtime_returning(devnet_sweep::derived_outcome())).await;
credit_finalized_sweeps(&runtime_returning(
sweep_signature,
devnet_sweep::derived_outcome(),
))
.await;

EventsAssert::from_recorded().expect_contains_event_eq(EventType::CreditedSweep {
signature: sweep_signature,
Expand Down Expand Up @@ -158,7 +165,7 @@ async fn should_keep_deposits_finalized_until_the_outcome_can_be_read() {
let events_before = EventsAssert::from_recorded();
let runtime = TestCanisterRuntime::new()
.with_increasing_time()
.add_stub_response(response());
.expect_get_transaction(sweep_signature, response());

credit_finalized_sweeps(&runtime).await;

Expand Down Expand Up @@ -190,7 +197,7 @@ async fn should_quarantine_deposits_if_the_outcome_does_not_match_the_plan() {
let mut outcome = devnet_sweep::derived_outcome();
devnet_sweep::set_balances(&mut outcome, devnet_sweep::minter_main_address(), 1, 0);

credit_finalized_sweeps(&runtime_returning(outcome)).await;
credit_finalized_sweeps(&runtime_returning(sweep_signature, outcome)).await;

EventsAssert::from_recorded().expect_contains_event_eq(EventType::QuarantinedSweep {
signature: sweep_signature,
Expand Down Expand Up @@ -235,10 +242,13 @@ fn finalize_devnet_sweep() -> Signature {
sweep_signature
}

fn runtime_returning(outcome: EncodedConfirmedTransactionWithStatusMeta) -> TestCanisterRuntime {
fn runtime_returning(
sweep_signature: Signature,
outcome: EncodedConfirmedTransactionWithStatusMeta,
) -> TestCanisterRuntime {
TestCanisterRuntime::new()
.with_increasing_time()
.add_stub_response(transaction_response(outcome))
.expect_get_transaction(sweep_signature, transaction_response(outcome))
}

fn transaction_response(
Expand Down
Loading
Loading