chore: fix hosting examples — upgrade to @dfinity/asset-canister@v2.2.1#1377
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Switch all three hosting workflows from manual npm install to container: ghcr.io/dfinity/icp-dev-env-all:0.3.2 (no ic-mops/ic-wasm needed — these are pure asset canister examples) - Add hosting/static-website to the PR: bump @dfinity/asset-canister v2.1.0 → v2.2.1 and modernize its workflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace src/<canister_name>/ nesting with a flat frontend/ directory in both unity-webgl-template and godot-html5-template: src/<name>/assets/ → frontend/assets/ src/<name>/src/index.html → frontend/index.html Also: - godot: rename canister from godot_html5_assets → frontend - godot: bump @dfinity/asset-canister v2.1.0 → v2.2.1 - godot: add CI workflow (was missing) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@dfinity/asset-canisterfromv2.1.0tov2.2.1in bothhosting/photo-storageandhosting/unity-webgl-template(v2.1.0 dropped support for theassetssync step)frontendper AGENTS.md conventions (photo-storage→frontend,unity_webgl_template_assets→frontend)npm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasm ic-mops, no provision scripts, no macOS runner, no pre-download-launcherTest plan
hosting-photo-storageworkflow passes on the PRhosting-unity-webglworkflow passes on the PRicp.yamlfiles reference@dfinity/asset-canister@v2.2.1and canister namefrontend🤖 Generated with Claude Code