chore: bump cryptography to 50 in rosetta-api - #11071
Merged
Merged
Conversation
The previous version has a vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2026-69248 The changes here close the CVE fully after #11059 and #11050.
nmattia
marked this pull request as ready for review
August 7, 2026 13:24
nmattia
enabled auto-merge
August 7, 2026 13:24
|
✅ No security or compliance issues detected. Reviewed everything up to 842fd4f. Security Overview
Detected Code Changes
|
mbjorkqvist
approved these changes
Aug 10, 2026
mbjorkqvist
left a comment
mbjorkqvist
left a comment
Contributor
There was a problem hiding this comment.
Thanks @nmattia!
While not directly related to this PR, the examples are currently broken on master and on this branch (so unrelated to the cryptography bump). Bumping the following two dependencies would fix the issue - if you could do it in this PR I would appreciate it, but if not, let's just merge this and look into bumping the others later:
cffi==2.1.1
pycparser==3.0
pull Bot
pushed a commit
to mikeyhodl/ic
that referenced
this pull request
Aug 10, 2026
…y#11081) <!-- ccr-slack-attribution --> _Requested by **Nicolas Mattia** · [Slack thread](https://dfinity.slack.com/archives/CL7Q2RXUM/p1786355727370839)_ ## What Bumps two Python dependencies used by the rosetta-api example clients: | Package | File(s) | Before | After | |---|---|---|---| | `cffi` | `rs/rosetta-api/examples/icp/python/requirements.txt`, `rs/rosetta-api/examples/icrc1/python/requirements.txt` | `1.17.1` | `2.1.1` | | `pycparser` | same as above | `2.22` | `3.0` | ## Why In [dfinity#11071](dfinity#11071) (bumping `cryptography` to `50.0.0` to close a CVE), @mbjorkqvist noted in review: > While not directly related to this PR, the examples are currently broken on `master` and on this branch (so unrelated to the `cryptography` bump). Bumping the following two dependencies would fix the issue - if you could do it in this PR I would appreciate it, but if not, let's just merge this and look into bumping the others later: > > ``` > cffi==2.1.1 > pycparser==3.0 > ``` dfinity#11071 was merged without that follow-up bump ("let's just merge this and look into bumping the others later"). This PR addresses that deferred suggestion by bumping `cffi` and `pycparser` to the exact versions Mathias suggested, which should fix the currently-broken rosetta-api python examples. --- _Generated by [Claude Code](https://claude.ai/code/session_017pV4aVSagxQ5MYVJB4xeeT)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version has a vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2026-69248
The changes here close the CVE fully after
#11059 and
#11050.