feat: make package param optional, use canister name as default (Rust recipe)#27
Open
marc0olo wants to merge 5 commits into
Open
feat: make package param optional, use canister name as default (Rust recipe)#27marc0olo wants to merge 5 commits into
marc0olo wants to merge 5 commits into
Conversation
Drop the `package` configuration parameter — the canister name is now
injected automatically via {{_.canister.name}} (requires icp-cli#567).
The Cargo package name in Cargo.toml must match the canister name in
icp.yaml, which was already the implicit convention.
BREAKING CHANGE: `package` param removed. Ensure the canister name in
icp.yaml matches [package].name in Cargo.toml.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep package as an optional override for cases where the Cargo package name differs from the canister name (e.g. workspaces). When omitted, _.canister.name is used — making this a non-breaking change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packagean optional parameter — when omitted, the canister name fromicp.yamlis used automatically via{{_.canister.name}}package:continue to work unchangedpackageis useful when the Cargo package name differs from the canister name (e.g. in a workspace)Convention
By default, name the canister in
icp.yamlto match[package].nameinCargo.toml— no configuration needed:Use
packageonly when the names genuinely differ (e.g. workspace):Blocked on
dfinity/icp-cli#567 — provides
{{_.canister.name}}built-in variable🤖 Generated with Claude Code