fix(asset-canister): bump sync plugin to v2.2.1#29
Merged
Conversation
Point the sync step at the new migration-v2.2.1-6b48585 plugin release on dfinity/certified-assets. The new plugin fixes a sync failure when the recipe's `dir` is a nested path (e.g. `src/frontend/dist`): the previous plugin called `canonicalize`, which under WASI returns ENOENT for any path beneath a preopened dir whose guest name has more than one component, even though plain access works. Single-component dirs like `dist` were unaffected. Canister wasm is unchanged (still the legacy dfx assetstorage canister). - URL: https://github.com/dfinity/certified-assets/releases/download/migration-v2.2.1-6b48585/sync_plugin.wasm - sha256: ca7cb5666c30d2875f8d5e10535f8a53f97a86c79c263f7d5bdac2fdd1bbf83c Plugin fix: dfinity/certified-assets#71 Reported: https://forum.dfinity.org/t/icp-cli-announcements-and-feedback-discussion/60410/97
raymondk
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the asset-canister recipe's sync plugin to the new
migration-v2.2.1-6b48585release on dfinity/certified-assets.Why
A user reported that
icp deployfailed during sync when the recipe'sdirwas a nested path such assrc/frontend/dist:The v2.2.0 plugin called
canonicalizeduring its scan step. Under WASI that callsrealpath, which returnsENOENTfor any path beneath a preopened directory whose guest name has more than one component (e.g.src/frontend/dist) — even though ordinary access works. Single-component dirs likedisthappened to work, which is why our examples didn't catch it. The v2.2.1 plugin dropscanonicalize; fix + regression test in dfinity/certified-assets#71.Change
Only
recipes/asset-canister/recipe.hbs— the pluginurl+sha256:…/migration-v2.2.0-209d688/sync_plugin.wasm…/migration-v2.2.1-6b48585/sync_plugin.wasm297c2ef0…ca7cb566…The canister wasm is unchanged (still the legacy dfx
assetstoragecanister), so this is a drop-in patch bump for existing users.Releasing
After merge, push the
asset-canister-v2.2.1tag to triggerrelease-recipe.ymland publish the recipe release.Ref: https://forum.dfinity.org/t/icp-cli-announcements-and-feedback-discussion/60410/97