chore: use the asset canister cookie to lookup the root key#31
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the hello-world frontend templates to source both canister IDs and the replica root key from the ic_env cookie served by the asset canister (and injected by the Vite dev server), so the actor is configured using cookie-derived configuration rather than environment-conditional root key fetching.
Changes:
- Switch frontends to use
getCanisterEnv(...)for canister ID lookup and root key retrieval from the asset-canister cookie. - Update actor creation to always set
agentOptions.rootKeyfromcanisterEnv.IC_ROOT_KEY. - Add inline documentation explaining the
PUBLIC_CANISTER_ID:<canister-name>convention and the cookie behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| hello-world/vue-frontend/src/App.vue | Moves env/root key lookup to getCanisterEnv, but currently introduces compile/runtime issues (TS syntax in non-TS SFC, missing import, actor name mismatch). |
| hello-world/react-frontend/src/App.tsx | Uses getCanisterEnv and always sets rootKey from cookie; comment wording updates needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
adamspofford-dfinity
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.