Skip to content

chore: use the asset canister cookie to lookup the root key#31

Merged
raymondk merged 4 commits into
mainfrom
rk/remove-meta-import
Jun 9, 2026
Merged

chore: use the asset canister cookie to lookup the root key#31
raymondk merged 4 commits into
mainfrom
rk/remove-meta-import

Conversation

@raymondk

@raymondk raymondk commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the hello-world frontend templates to source both canister IDs and the replica root key from the ic_env cookie served by the asset canister (and injected by the Vite dev server), so the actor is configured using cookie-derived configuration rather than environment-conditional root key fetching.

Changes:

  • Switch frontends to use getCanisterEnv(...) for canister ID lookup and root key retrieval from the asset-canister cookie.
  • Update actor creation to always set agentOptions.rootKey from canisterEnv.IC_ROOT_KEY.
  • Add inline documentation explaining the PUBLIC_CANISTER_ID:<canister-name> convention and the cookie behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
hello-world/vue-frontend/src/App.vue Moves env/root key lookup to getCanisterEnv, but currently introduces compile/runtime issues (TS syntax in non-TS SFC, missing import, actor name mismatch).
hello-world/react-frontend/src/App.tsx Uses getCanisterEnv and always sets rootKey from cookie; comment wording updates needed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hello-world/vue-frontend/src/App.vue
Comment thread hello-world/vue-frontend/src/App.vue Outdated
Comment thread hello-world/vue-frontend/src/App.vue
Comment thread hello-world/vue-frontend/src/App.vue Outdated
Comment thread hello-world/vue-frontend/src/App.vue Outdated
Comment thread hello-world/react-frontend/src/App.tsx Outdated
Comment thread hello-world/react-frontend/src/App.tsx Outdated
@raymondk raymondk marked this pull request as draft June 8, 2026 21:07
raymondk and others added 3 commits June 8, 2026 17:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@raymondk raymondk marked this pull request as ready for review June 8, 2026 21:35
@raymondk raymondk requested a review from Copilot June 8, 2026 21:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread hello-world/vue-frontend/src/App.vue
@raymondk raymondk merged commit 541968c into main Jun 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants