Skip to content

perf(chunker): lazy facets map + strconv.FormatUint in mapToNquads #9716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaunpatterson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(chunker): lazy facets map + strconv.FormatUint in mapToNquads #9716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions chunker/json_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,10 +397,13 @@ func getNextBlank() string {
func (buf *NQuadBuffer) mapToNquads(m map[string]interface{}, op int, parentPred string) (mapResponse, error) {
var mr mapResponse

// move all facets from global map to smaller mr.rawFacets map
mr.rawFacets = make(map[string]interface{})
// move all facets from global map to smaller mr.rawFacets map. The vast majority
// of input objects have no facet keys, so allocate the map lazily on first hit.
for k, v := range m {
if strings.Contains(k, x.FacetDelimiter) {
if mr.rawFacets == nil {
mr.rawFacets = make(map[string]interface{})
}
mr.rawFacets[k] = v
delete(m, k)
}
Expand Down Expand Up @@ -437,7 +440,7 @@ func (buf *NQuadBuffer) mapToNquads(m map[string]interface{}, op int, parentPred
}
}
if uid > 0 {
mr.uid = fmt.Sprintf("%d", uid)
mr.uid = strconv.FormatUint(uid, 10)
}
}

Expand Down
Loading