Conversation
dharmab
force-pushed
the
vectors
branch
5 times, most recently
from
7346468 to
7b0adae
Compare
Adapt Bullseye usage to interface type: remove pointer-to-interface patterns, fix dereference of interface values, and update test call signatures for the new Parser.New parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dharmab
commented
Mar 22, 2026
- Refactor Vector/Bullseye/BRA/BRAA from interfaces to public structs
following idiomatic Go "return structs, accept interfaces"
- Remove redundant conf.Location; use locations.Location directly
- Load locations from file and pass to parser and controller
- Validate reserved location names ("tanker", "bullseye") at startup
- Mark --locations-file as filename flag for shell completion
- Remove unnecessary loc import alias
- Add missing godocs on public symbols
- Fix double comment in vector.go
- Update LOCATIONS.md wording for non-server users
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add AirRefuelingMethod type with FlyingBoom and ProbeAndDrogue constants. Tankers now indicate which method they provide, and receivers indicate which method they require. This enables matching receivers to compatible tankers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a player requests "vector to tanker", the system looks up the player's aircraft refueling method, finds the nearest compatible friendly tanker, and responds with BRA (bearing, range, altitude), track direction, and the tanker's in-game callsign. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Accept both JSON and YAML for the locations file by trying JSON first and falling back to YAML. Update documentation with YAML examples and add a custom locations section to the admin guide. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update documentation examples to match actual composer code behavior: - PICTURE: use controller callsign instead of player callsign - SPIKED/STROBE: remove "single contact" (code omits count for single) - STROBE: use "strobe range" instead of "spike range" - SPIKED clean: use subtitle format with numeric bearing and period - VECTOR: remove extra controller callsign, add comma before bearing - VECTOR tanker: use "nearest tanker" BRA format with altitude/track - DECLARE: add missing "group" label - SNAPLOCK: use numeral "2 contacts" instead of "two contacts" - README: add VECTOR to supported commands list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dharmab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.