Upgrade whisper.cpp from v1.7.2 fork to upstream v1.8.4#651
Open
Upgrade whisper.cpp from v1.7.2 fork to upstream v1.8.4#651
Conversation
Switch from dharmab/whisper.cpp fork (v1.7.2-windows-fix) to upstream ggml-org/whisper.cpp v1.8.4. The Windows build fix from the fork is now in upstream. - Replace Make-based build with CMake - Update LIBRARY_PATH for new cmake output layout (split ggml libraries) - Add CGO_LDFLAGS=-fopenmp on macOS for ggml-cpu OpenMP linkage - Pass CMAKE_C_COMPILER/CMAKE_CXX_COMPILER on macOS for Homebrew LLVM - Add cmake to all platform dependency install targets and CI - Update Go module to v1.8.4 bindings - Adapt Process() call for new 4-argument signature (added EncoderBeginCallback) Benchmarked on M4 MacBook Air: small model 0.26-0.46s (baseline 0.35-0.5s), medium model 0.86-1.07s (baseline 1.1-1.5s) — ~20-30% faster on medium. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
macOS: Add -Wno-elaborated-enum-base to suppress Homebrew LLVM errors from Apple SDK headers (vDSP.h) when compiling ggml-blas. Windows: Force "MSYS Makefiles" generator and CMAKE_STATIC_LIBRARY_PREFIX=lib so CMake outputs libggml.a instead of ggml.a, matching what -lggml expects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CMake on MSYS2 outputs ggml.a, ggml-base.a, ggml-cpu.a without the "lib" prefix. CMAKE_STATIC_LIBRARY_PREFIX doesn't propagate to the ggml subdirectory. Instead, rename any .a files missing the prefix after build so the linker's -lggml flags can find them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dharmab/whisper.cppfork (v1.7.2-windows-fix) to upstreamggml-org/whisper.cppv1.8.4— the Windows build fix from the fork is now in upstreamProcess()call for new 4-argument signaturecmakeas a dependency across all platforms (Makefile install targets, CI, Dockerfile)CGO_LDFLAGS=-fopenmpon macOS to link OpenMP runtime for ggml-cpu (Go bindings only specify-fopenmpon Linux)Benchmarks (M4 MacBook Air)
.envariant)~20-30% faster on the medium model.
Test plan
make whisper— cmake clone + build succeedsmake test— all 937 tests passmake lint && make vet && make fix && make format && go mod tidy— CI checks pass🤖 Generated with Claude Code