Skip to content

Improve performance of time and column conversions#603

Open
Cybermaxke wants to merge 1 commit intodhatim:masterfrom
Cybermaxke:perf-improvements
Open

Improve performance of time and column conversions#603
Cybermaxke wants to merge 1 commit intodhatim:masterfrom
Cybermaxke:perf-improvements

Conversation

@Cybermaxke
Copy link
Copy Markdown

  • Improved time based conversion performance by avoiding calendar creation
    • Epoch millis calculation avoids toInstant() where possible to avoid extra allocations
  • Improved column name generation by caching frequently used ones (1024 should be enough?)
  • Added value setter for Instant to pass UTC based timestamps, no conversions based on system time zone
  • Adjusted the benchmark to use LocalDateTime instead of Date to reduce extra conversions
Before:
WriterBenchmark.fastExcel    ss   15  0,219 ± 0,004   s/op

After:
WriterBenchmark.fastExcel    ss   15  0,194 ± 0,010   s/op

Signed-off-by: Seppe Volkaerts <seppevolkaerts@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant