Repository navigation
Preserve run logs and harden startup lifecycle and failure handling - #167
Claude-Reverser wants to merge 2 commits into
Conversation
|
please rewrite this in your own words |
|
My bad, I did not notice my agent did a PR. Alright basically, my S23 Ultra was doing a kernel panic right after it said success and I couldnt get useful logs afterwards. This fixes the error when there’s no KSU modules folder, saves the logs and stops duplicate runs. I’ve now tested these changes in my Samsung-specific build after a full reboot, with “Disable KSU Modules” off, and root worked without another reboot. I still haven’t confirmed what caused the earlier kernel panics, so I can’t fully claim this fixes those yet. |
|
I'm so confused, so this PR doesn't fix anything or it does?
…On Tue, Oct 20, 2026, 9:37 PM Claude reverser ***@***.***> wrote:
*Claude-Reverser* left a comment (diabl0w/DFRoot#167)
<#167 (comment)>
My bad, I did not notice my agent did a PR.
Alright basically, my S23 Ultra was doing a kernel panic right after it
said success and I couldnt get useful logs afterwards. This fixes the error
when there’s no KSU modules folder, saves the logs and stops duplicate
runs. I’ve now tested these changes in my Samsung-specific build after a
full reboot, with “Disable KSU Modules” off, and root worked without
another reboot. I still haven’t confirmed what caused the earlier kernel
panics, so I can’t fully claim this fixes those yet.
—
Reply to this email directly, view it on GitHub
<#167?email_source=notifications&email_token=AD3BYMXMBEBHN3NALNS55335VAHNJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4DIOJQGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6305849010>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3BYMRHJLD3TWHX5NTFA4L5VAHNJAVCNFSNUABGKJSXA33TNF2G64TZHMYTGOBXGAZDSOJVGA5US43TOVSTWNJZGQZTENRVHEYDRILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AD3BYMSJJRGTE22FYEHOMNT5VAHNJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4DIOJQGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AD3BYMSA6E6ZJ2Q3ILQ337T5VAHNJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4DIOJQGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
|
It fixes the kernel panic when no modules are there. |
|
which part?
…On Tue, Oct 20, 2026, 9:48 PM Claude reverser ***@***.***> wrote:
*Claude-Reverser* left a comment (diabl0w/DFRoot#167)
<#167 (comment)>
It fixes the kernel panic when no modules are there.
—
Reply to this email directly, view it on GitHub
<#167?email_source=notifications&email_token=AD3BYMXLO6BPXE3PQX7TLYT5VAIWFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4TQOBVGEY2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6305988511>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3BYMV7VJNOL2L4IGT3FK35VAIWFAVCNFSNUABGKJSXA33TNF2G64TZHMYTGOBXGAZDSOJVGA5US43TOVSTWNJZGQZTENRVHEYDRILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AD3BYMQ7TUDUAGVCD2OXBST5VAIWFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4TQOBVGEY2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AD3BYMQN37J77YLYOHCDTFT5VAIWFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMZQGU4TQOBVGEY2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Alright my bad i mixed up the custom build with this PR. My phone would kernel panic just from pressing "Launch Root" with all options off. The custom Samsung build now works without that crash, but those Samsung KernelSU changes arent included here. (I can make a separate PR for this fix) The fix here is in |
|
users enabling that option do so because they are having issues, so unexpected errors should prefer to abort rather than continue with root, which is what the code already does |
DFRoot currently ties live output to one screen instance, exposes boot results only through logcat, and can label an early startup marker or launcher exit as root success. This change preserves bounded current/previous diagnostics, adds log export without root, and keeps one active run owned through native completion and cleanup. Interrupted attempts and launcher completion are reported without claiming usable root.
Changes:
tools/collect_logs.pyfor DFRoot-tag logcat and selected version/boot metadata, bounded watch capture with reconnection to the selected serial, and optional protected diagnostics using existing root access. It does not clear logs, change settings, start DFRoot, reboot, or upload files.Validation:
:app:assembleDebugand:app:lintDebugwith compile/target SDK 37, minimum SDK 32, and NDK 28.2.13676358. Lint reports 0 errors and 16 existing warnings. A targeted manifest suppression documents the existing broad package visibility required to discover compatible SU managers by native payload; discovery behavior is preserved.c274137e8c02b4f94f64d1b132d991b80c747340. No kernel-module source was changed or new kernel support claimed.The expanded changes have not been installed on a device. Foreground-service behavior, boot startup, root acquisition, enabled-module recovery, and reset durability still need hardware validation. Notification-disabled Android may expose the service only in Task Manager, and an abrupt reset can still lose the buffered log tail.
The original report did not include filesystem errno, so its exact module-disable failure remains unknown. Recovery with Disable KSU Modules enabled on the affected phone remains untested. Root was previously verified using a separate experimental build with that option OFF; that does not validate this patch. This PR does not claim to resolve the separately observed kernel panic.