This repository was archived by the owner on Jun 17, 2024. It is now read-only.
ES2015#22
Open
marcobiedermann wants to merge 1 commit intodifelice:masterfrom
marcobiedermann:feature/es2015
Open
ES2015#22marcobiedermann wants to merge 1 commit intodifelice:masterfrom marcobiedermann:feature/es2015
marcobiedermann wants to merge 1 commit intodifelice:masterfrom
marcobiedermann:feature/es2015
Conversation
Collaborator
No, this is not how restructuring in imports/requires works. Your change won't affect the bundle size. Another problem with your change is that destructuring doesn't work in Node 4 so you need to upgrade / specify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've translated the syntax to ES2015. This way you can make use of the import destructure operator to only include the functions you really need. This will reduce the file size and improves the performance overall.