cprover: only equate same-address-type pairs in axiom field-condition eval#9067
Open
tautschnig wants to merge 1 commit into
Open
cprover: only equate same-address-type pairs in axiom field-condition eval#9067tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
… eval In axiomst::evaluate_fc, two evaluate expressions can only alias when their object addresses have the same type; skip incompatible-address-type pairs rather than conditionally typecasting one address to the other's type. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tightens alias checking in axiomst::evaluate_fc by only equating pairs of evaluated addresses when their address expression types match, avoiding conditional casting between incompatible pointer types.
Changes:
- Add an early-continue to skip address pairs whose
type()differs. - Remove
conditional_castofb_it->address()toa_it->address().type()and compare original address expressions directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+70
to
+71
| if(a_it->address().type() != b_it->address().type()) | ||
| continue; |
Comment on lines
+68
to
+69
| // Skip pairs with incompatible address types — they can never | ||
| // point to the same location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In axiomst::evaluate_fc, two evaluate expressions can only alias when their object addresses have the same type; skip incompatible-address-type pairs rather than conditionally typecasting one address to the other's type.