goto-check: skip array bounds checks for unbounded (non-constant-size) arrays#9070
Open
tautschnig wants to merge 1 commit into
Open
Conversation
…) arrays An array whose size is not a constant denotes an unbounded array; emitting an array-bounds check over its (non-constant/nil) size is meaningless and cannot be lowered to SMT. Skip the bounds check in that case. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates goto_check_ct::bounds_check_index to avoid generating array-bounds checks for arrays whose declared size is not a compile-time constant, based on the rationale that such checks are not meaningful / not lowerable to SMT for “unbounded arrays”.
Changes:
- Add an early return to skip bounds checks for
ID_arraywheresize()is not constant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1596
to
+1600
| // Skip bounds checking for unbounded arrays (no constant size). | ||
| if( | ||
| array_type.id() == ID_array && | ||
| !to_array_type(array_type).size().is_constant()) | ||
| return; |
Comment on lines
+1596
to
+1600
| // Skip bounds checking for unbounded arrays (no constant size). | ||
| if( | ||
| array_type.id() == ID_array && | ||
| !to_array_type(array_type).size().is_constant()) | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An array whose size is not a constant denotes an unbounded array; emitting an array-bounds check over its (non-constant/nil) size is meaningless and cannot be lowered to SMT. Skip the bounds check in that case.