pointer_expr: object-address of struct members with non-constant width#9071
Open
tautschnig wants to merge 1 commit into
Open
pointer_expr: object-address of struct members with non-constant width#9071tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
When the byte offset of a struct member cannot be computed (struct with non-constant-width members), fall back to using the member expression itself as the object rather than asserting. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates build_object_descriptor_rec to avoid asserting when a struct member’s byte offset can’t be computed (e.g., structs with non-constant-width members) by falling back to treating the member expression itself as the object.
Changes:
- Replaced
CHECK_RETURN(offset.has_value())with a fallback path when the member offset is unavailable. - Sets the object descriptor’s object to the member expression and exits early in the fallback case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+70
| if(!offset.has_value()) | ||
| { | ||
| // Cannot compute offset for structs with non-constant-width members; | ||
| // set object to the member expression itself | ||
| dest.object() = member; | ||
| return; | ||
| } |
Comment on lines
+64
to
+70
| if(!offset.has_value()) | ||
| { | ||
| // Cannot compute offset for structs with non-constant-width members; | ||
| // set object to the member expression itself | ||
| dest.object() = member; | ||
| return; | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9071 +/- ##
========================================
Coverage 80.68% 80.68%
========================================
Files 1714 1714
Lines 189501 189503 +2
Branches 73 73
========================================
+ Hits 152902 152905 +3
+ Misses 36599 36598 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the byte offset of a struct member cannot be computed (struct with non-constant-width members), fall back to using the member expression itself as the object rather than asserting.