Repository navigation
Correct stale comments in the relay push path, managed voice, the native direct-peer test, and the browser specs - #1233
Merged
Merged
Conversation
…ive direct-peer test, and the browser specs Co-Authored-By: Claude <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
f20d6af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba04c8ae.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-stale-comments-oct20.mouseterm.pages.dev |
dormouse-bot
commented
Oct 20, 2026
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
The native-direct-peer.test.ts header still says the shipped factory isn't used, only half fixed. Three cases build through createNativeDirectPeerFactory: Local networks (binds the one allowed address…), Anywhere (builds a peer through Cloudflare STUN…), and the teardown case. So "these cases inject a plain factory" is wrong for those three, and this PR exists to correct exactly that kind of comment.
…ive direct-peer test header
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and spec lines that recent commits left describing older code. No behavior changes.
relay/src/push.tsandrelay/src/app.tssaid delivery goes "throughweb-push", supplied byindex.ts. Since Harden Relay push registration and delivery #1226,web-pushonly builds the encrypted body and VAPID headers andpostToPushServicesends them;start.tsis what wires increateWebPushSender.remote-lib-common/src/security/acl.tsstill described a delivery id as 32 random bytes; it is now minted bymintPushDeliveryId(random bytes plus a tag).docs/specs/dor-cli.mdanddocs/specs/dor-browser.mdlisted onlydor-embed-sizeas handled by Dormouse rather than the provider;dor-diagnostics(Keep an agent-browser screencast on the tab it shows, size every shown page, and add dor-diagnostics for a frozen pane #1176) is too.dor-browser.mdalso had a sentence missing its subject ("The desktop playground's fronts…") and a rule citingviewerTextInputswhoseSource of truth:line didn't name the file that holds it.media-src blob:; the VS Code webview does too since Managed voice in VS Code #1000. The serial-queue comment inmanaged-voice-host.tsstill described rewriting a whole file, which theManagedVoiceStoresplit replaced.native-direct-peer.test.ts— the doc block for the last case ("last because its teardown is the process's") had been separated from it when the reliability case was inserted, so it sat on the wrong test. Moved it back, and corrected the header andNegotiation.abandondoc, which no longer matched how the cases use the shipped factory andabandon.send.tsnamescli-core.ts(notcli.ts) as the caller ofpreParse;security-audit.yamlcites theTag operations/Merge accessrulesets instead of a "§3" thatsecurity-ci.mddoesn't have;setup-token.tssays "outstanding" rather than "live" tokens, matching what#trimBurrowcounts;entitlement.tsdescribes the alias parameter correctly;tut-runner.tsdrops a reference to aflappy-term.htmlthat was never in the repo; the pairing walkthrough README no longer says in bold that nothing is written into the repo while its Known limitations say Burrow staging is.node scripts/spec-lint.mjspasses locally; the rest is left to CI, since the sandbox has nopnpm.